HBASE-22338 LICENSE file only contains Apache 2.0. #41
HBASE-22338 LICENSE file only contains Apache 2.0. #41rabi-kumar wants to merge 4 commits intoapache:masterfrom
Conversation
…notice file in each of the sub-module.
|
Refer to this link for build results (access rights to CI server needed): |
kafka/hbase-kafka-model/src/main/appended-resources/META-INF/LICENSE.txt
Outdated
Show resolved
Hide resolved
kafka/hbase-kafka-model/src/main/appended-resources/META-INF/LICENSE.txt
Outdated
Show resolved
Hide resolved
| ---- | ||
| This product includes ParaNamer Core Module version 2.3 | ||
| under the terms of the BSD license which can be found at: | ||
| https://github.com/paul-hammant/paranamer/blob/master/LICENSE.txt |
There was a problem hiding this comment.
better if we could link to a REF, or atleast tag specific to the release version
kafka/hbase-kafka-model/src/main/appended-resources/META-INF/NOTICE.txt
Outdated
Show resolved
Hide resolved
kafka/hbase-kafka-model/src/main/appended-resources/META-INF/NOTICE.txt
Outdated
Show resolved
Hide resolved
| other than Apache Software License Version 2. See LICENSE for full details | ||
|
|
||
| ---- | ||
| This product includes the SLF4J API Module |
There was a problem hiding this comment.
are these things that end up in the jar file for hbase-kafka-model? it doesn't seem like we should.
There was a problem hiding this comment.
I checked the dependency file of hbase-kafka-model in targe/META-INF/DEPENDENCY SLF4J API Module was present there
There was a problem hiding this comment.
that file just tells some tools that look at the jar what dependencies are needed at runtime. It doesn't mean we're packaging and distributing them.
a given LICENSE/NOTICE set of files should only cover the artifact they're found in. So each of these module should have a src/main/appended-resources/META-INF/LICENSE/NOTICE based on the contents of the jar that will be made by that module.
the only case where these would include dependencies is if we are making a "fat jar" or using the maven shade plugin to package our dependency into the jar.
I think that means for the connectors repo, it's only the convenience binary tarball that needs the aggregate information about our dependencies.
kafka/hbase-kafka-proxy/src/main/appended-resources/META-INF/LICENSE.txt
Outdated
Show resolved
Hide resolved
kafka/hbase-kafka-proxy/src/main/appended-resources/META-INF/LICENSE.txt
Outdated
Show resolved
Hide resolved
spark/hbase-spark-it/src/main/appended-resources/META-INF/LICENSE.txt
Outdated
Show resolved
Hide resolved
…made as suggested by Sean Busbey.
|
Refer to this link for build results (access rights to CI server needed): |
|
@busbey I have made the necessary changes as suggested above. Please let me know if there still are changes that need to be made. |
| ---- | ||
| This product includes ParaNamer Core Module version 2.3 | ||
| under the terms of the BSD license which can be found at: | ||
| https://github.com/paul-hammant/paranamer/releases/tag/paranamer-2.3 |
There was a problem hiding this comment.
I think the correct link is
https://github.com/paul-hammant/paranamer/blob/paranamer-2.3/LICENSE.txt
| other than Apache Software License Version 2. See LICENSE for full details | ||
|
|
||
| ---- | ||
| This product includes the SLF4J API Module |
There was a problem hiding this comment.
that file just tells some tools that look at the jar what dependencies are needed at runtime. It doesn't mean we're packaging and distributing them.
a given LICENSE/NOTICE set of files should only cover the artifact they're found in. So each of these module should have a src/main/appended-resources/META-INF/LICENSE/NOTICE based on the contents of the jar that will be made by that module.
the only case where these would include dependencies is if we are making a "fat jar" or using the maven shade plugin to package our dependency into the jar.
I think that means for the connectors repo, it's only the convenience binary tarball that needs the aggregate information about our dependencies.
|
|
||
| ---- | ||
| This product includes following under | ||
| The Apache Software License, Version 2.0 |
There was a problem hiding this comment.
things under the ALv2 license don't need have the license repeated here. I think the mention that we're distributing them under ALv2 should be in the NOTICE file.
|
Refer to this link for build results (access rights to CI server needed): |
|
Thank you for the detailed explanation @busbey . If there are issues and changes required then please do let me know. |
|
This conversation on which LICENSE/NOTICE files need to change is still an issue AFAICT I did a quick glance at our pom files and I don't think we're including these dependencies in any of our generated jar files. So I think the only place that should have these changes is the connectors assembly module since it controls what goes into our convenience tarball. |
|
@busbey If that is the case then I can aggregate these and add them in assembly module but in hbase-connectors-assembly aggregated notice and license files are auto-generated in target/META-INF/maven-shared-archive-resources. So I don't know if it's necessary to add them but please do let me know if it's needed. |
|
yes I believe the assembly module is the only place we need to have this information. the stuff that's getting autogenerated right now is the implementation based on the main repo that I mentioned earlier. you can turn it off by removing the plugins that drive the executions |
…notice files in assembly, removed plugins aggregating license and notice files for hbase repo in assembly pom
|
Refer to this link for build results (access rights to CI server needed): |
|
@busbey I have added the aggregated license and notice files in assembly module under src/main/resources and removed the plugins from assembly module which generated aggregated license and notice files for hbase-repo. Please do have a look at them in case if any changes are to be made. |
|
💔 -1 overall
This message was automatically generated. |
|
@busbey @ravowlga123 do we need something for this change or can I merge it? |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
will this block 1.0.1 release ? if so, I (or @rabi-kumar if he is still around) may pick this up. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
sorry if above conversation is a long long time ago, I want to clarify your comment above, if I read all your conversations correctly, @busbey you're basically saying we don't need this PR because below block of hbase-connectors/hbase-connectors-assembly/pom.xml Lines 93 to 126 in 2bfc5f1 I just open another one that fix the |
|
036729d pushed, so closing this PR |
Added license and notice files in each of the sub-module.